Make Soldeer Dependency field public #10038
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TilakMaddy
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse and
yash-atreya
as code owners
mattsse
requested changes
Mar 9, 2025
DaniPopes
added a commit
that referenced
this pull request
Aug 12, 2025
This PR aggregates changes from the following PRs: - #10038: Make Soldeer Dependency field public by @TilakMaddy - #11139: upgrade to Node.js 24 by @Daulox92 - #11274: CI: migrate workflows to checkout v5 by @rejected-l - #11246: fix: add missing semicolon in typos error message in Makefile by @dizer-ti
DaniPopes
added a commit
that referenced
this pull request
Aug 12, 2025
This PR aggregates changes from the following PRs: - #10038: Make Soldeer Dependency field public by @TilakMaddy - #11139: upgrade to Node.js 24 by @Daulox92 - #11274: CI: migrate workflows to checkout v5 by @rejected-l - #11246: fix: add missing semicolon in typos error message in Makefile by @dizer-ti
auto-merge was automatically disabled
August 12, 2025 11:16
Pull request was closed
MerkleBoy
pushed a commit
to MerkleBoy/foundry
that referenced
this pull request
Sep 17, 2025
…11274, foundry-rs#11246 (foundry-rs#11279) This PR aggregates changes from the following PRs: - foundry-rs#10038: Make Soldeer Dependency field public by @TilakMaddy - foundry-rs#11139: upgrade to Node.js 24 by @Daulox92 - foundry-rs#11274: CI: migrate workflows to checkout v5 by @rejected-l - foundry-rs#11246: fix: add missing semicolon in typos error message in Makefile by @dizer-ti
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It would help application crates access the field for processing
Solution
Add a visibility modifier
PR Checklist