anvil: make max on disk history limit configurable

[mattsse]

Component

Anvil

Describe the feature you would like

foundry/crates/anvil/src/eth/backend/mem/storage.rs

Lines 45 to 46 in 82ff8ee

	// 1hr of up-time at lowest 1s interval
	const MAX_ON_DISK_HISTORY_LIMIT: usize = 3_600;

we already have this for the memory limit

foundry/crates/anvil/src/eth/backend/mem/storage.rs

Lines 77 to 78 in 82ff8ee

	min_in_memory_limit: limit.min(MIN_HISTORY_LIMIT),
	max_on_disk_limit: MAX_ON_DISK_HISTORY_LIMIT,

foundry/crates/anvil/src/cmd.rs

Lines 160 to 163 in 82ff8ee

	/// Don't keep full chain history.
	/// If a number argument is specified, at most this number of states is kept in memory.
	#[arg(long)]
	pub prune_history: Option<Option<usize>>,

maybe those can even be combined, because I think the
--prune_history is slightly confusing

So I think this should be fixed by setting

foundry/crates/anvil/src/eth/backend/mem/storage.rs

Line 78 in 82ff8ee

max_on_disk_limit: MAX_ON_DISK_HISTORY_LIMIT,

to limit

Additional context

No response

[qiweiii]

I would like to try take this

[mattsse]

assigned,

I fixed a link above that provided relevant context:

max_on_disk_limit: MAX_ON_DISK_HISTORY_LIMIT

[qiweiii]

after set it to limit, I am a bit confused by --prune_history, if user don't enable it, it uses default limit of 500, so both in memory and max disk cache length will be 500

but if user enabled it, the state will be memory only:

foundry/crates/anvil/src/eth/backend/mem/storage.rs

Lines 84 to 87 in 642f13f

	/// Configures no disk caching
	pub fn memory_only(mut self) -> Self {
	self.max_on_disk_limit = 0;

it overwrites the max_on_disk_limit set in InMemoryBlockStates::new, so setting

foundry/crates/anvil/src/eth/backend/mem/storage.rs

Line 78 in 82ff8ee

max_on_disk_limit: MAX_ON_DISK_HISTORY_LIMIT,

to limit has no effect, then max_on_disk_limit is still not configurable, it's default 500 or 0, maybe need a separate config for this?

[mattsse]

ah you're right so restricting this with --prune-history doesn't have any effect actually

so this issue is kinda pointless...

[grandizzy]

I think we should expose --max-persisted-states arg (or a better name, defaults to 3600 to keep current settings), to control value of InMemoryBlockStates.max_on_disk_limit that would basically make current --prune-history behavior same as --max-persisted-states=0 (and alternatively drop the --prune-history one) wdyt? @mattsse @qiweiii

[qiweiii]

I agree, it needs a new arg to set its value

[mattsse]

I agree, it needs a new arg to set its value

this makes sense to me as well

[qiweiii]

@mattsse @grandizzy please check #8412 if this is what we want, it still feels a bit weired to have two config for in memory limit and on disk limit

[grandizzy]

@mattsse @grandizzy please check #8412 if this is what we want, it still feels a bit weired to have two config for in memory limit and on disk limit

thanks, I think that's OK, if I correctly understand there is only one config exposed for disk limit, that is the newly added --max-persisted-states, the memory limit is not configurable but set to const DEFAULT_HISTORY_LIMIT: usize = 500;
Maybe we can also drop the --prune-history and just add description that this can be accomplished by setting --max-persisted-states=0
@mattsse wdyt?