`forge test`/`forge script`: throw when ffi fails

[0xPhaze]

Component

Forge

Describe the feature you would like

I would expect the script to halt and throw when vm.ffi fails. Currently it (almost) silently continues and prints "Script ran successfully."

Additional context

No response

[mattsse]

@onbjerg this came up here #2520 as well.

from a DX perspective it'd be more convenient to simply print the error, even though it may not match the order of the test output

[cxkoda]

I'm facing a similar problem where all I'm interested in is the exit code of an external program.
For me it would be best if ffi returned something like (bytes memory result, uint8 errno). Might be worth considering to generalize it even further and give the caller full control over all outputs by returning something like (bytes memory stdout, bytes memory stderr, uint8 errno) via a dedicated cheatcode?

[mattsse]

I can see that this is useful, maybe we add a tryFfi cheatcode that returns both stdout and sterr @onbjerg ?

[gakonst]

Yeah supportive of tryFfi and returning the error code.