perf: parallelize Remapping::get_many #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
0xrusowsky,
grandizzy,
klkvr,
mattsse,
onbjerg,
yash-atreya and
zerosnacks
as code owners
DaniPopes
commented
Sep 3, 2025
| async = ["dep:tokio", "dep:futures-util"] | ||
| checksum = ["foundry-compilers-core/hasher"] | ||
| walkdir = ["dep:walkdir", "foundry-compilers-core/walkdir"] | ||
| walkdir = ["rayon", "foundry-compilers-core/walkdir"] |
There was a problem hiding this comment.
find module and related functions are gated by "walkdir", don't wanna change feature gate
DaniPopes
commented
Sep 3, 2025
| if entry.path_is_symlink() { | ||
| if let Ok(target) = utils::canonicalize(entry.path()) { | ||
| if !visited_symlink_dirs.insert(target.clone()) { | ||
| if file_type.is_symlink() { |
There was a problem hiding this comment.
this path is untested. foundry-rs/foundry#7820
DaniPopes
force-pushed
the
dani/par-remapping-find_many
branch
from
b6f22db to
a1cf3c2
Compare
mattsse
approved these changes
Sep 3, 2025
| async = ["dep:tokio", "dep:futures-util"] | ||
| checksum = ["foundry-compilers-core/hasher"] | ||
| walkdir = ["dep:walkdir", "foundry-compilers-core/walkdir"] | ||
| walkdir = ["rayon", "foundry-compilers-core/walkdir"] |
| // iterate over all dirs that are children of the root | ||
| for dir in walkdir::WalkDir::new(dir) | ||
| .sort_by_file_name() | ||
| .follow_links(true) |
There was a problem hiding this comment.
we dont need to follow symlinks explicitly here, right?
There was a problem hiding this comment.
why not, lib/x can be a symlink, it should be the same logic as the inner fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No logic changes except: 2nd commit removes walkdir and doesn't sort by file name anymore because order doesn't matter when we run it in parallel