Fetch apps from publish run #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mike-sul
commented
Feb 29, 2024
mike-sul
commented
- Fetch apps from the publish run if the download uri is specified in the target custom data.
- If not, then fallback to fetching apps from the assemble run. It requires fetching of the corresponding CI target json if the specified target is a prod or a wave target.
|
This is the corresponding changes in ci-scripts foundriesio/ci-scripts#324. |
vkhoroz
reviewed
Feb 29, 2024
19 tasks
- Use the custom data of the CI/wave/prod target by default - Fetch the corresponding CI target and use its custom data only if apps download is required and this is a prod or a wave target. Signed-off-by: Mike Sul <mike.sul@foundries.io>
- Fetch apps from the publish run if the download uri is specified in the target custom data. - If not, then fallback to fetching apps from the assemble run. It requires fetching of the corresponding CI target json if the specified target is prod or wave target. Signed-off-by: Mike Sul <mike.sul@foundries.io>
mike-sul
force-pushed
the
fetch-apps-from-publish-run
branch
from
5a890b2
to
d81c4d1
Compare
ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.