targets: offline-update: Check if dest dir already has data #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, however the |
detsch
force-pushed
the
check-offline-dst-dir
branch
from
d10b4ec
to
5347ddf
Compare
|
Updated changes replacing "--force" logic with "--allow-multiple-targets" |
mike-sul
approved these changes
Oct 10, 2023
vkhoroz
approved these changes
Oct 10, 2023
This commit prevents the execution of "targets offlile-update" using a destination directory that already contains update data (i.e., "ostree_repo" or "apps" subdirectories). There is no check for the tuf subdirectory, since the metadata in that subdir is updated by default, and there is no conflict. It is possible to override the default behavior by using a new --allow-multiple-targets option. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
detsch
force-pushed
the
check-offline-dst-dir
branch
from
5347ddf
to
4ef6f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents the execution of "targets offlile-update" using a destination directory that already contains update data (i.e., "ostree_repo" or "apps" subdirectories). There is no check for the tuf subdirectory, since the metadata in that subdir is updated by default, and there is no conflict.
The content of the destination directory can be cleaned up automatically if the new --force option is used.