Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests to check the CLI #276

Closed

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Sep 23, 2023

Description

This PR proposes to add a structure for we start to add e2e tests to validate the CLI

@camilamacedo86 camilamacedo86 force-pushed the add-e2e-tests branch 2 times, most recently from b14c30a to 645cab6 Compare September 23, 2023 19:43
Copy link
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hard part is developing the e2e tests. If we aren't going to commit to adding actual tests, this is just going to be noise.

@camilamacedo86
Copy link
Contributor Author

Hi @doanac,

The hard part is developing the e2e tests. If we aren't going to commit to adding actual tests, this is just going to be noise.

Appreciate your insight! 🎉 . IHMO the significant challenge lies in establishing the API and creating a factory for testing. Using prod is off the table. Ideally, we should deploy everything via GitHub actions, which seems unattainable to me.

So, why did I push this PR?

My thought was: If we run basic tests to check the build (https://github.com/foundriesio/fioctl/pull/275/files) and bin functionality (or alternatively, by testing one or two commands directly in GitHub actions against all supported matrix), then we can easily merge the auto PRs GitHub throws at us to update project deps—no overthinking needed! I understand that currently, we are a bit hesitant to merge any golang dep or image update because we aren’t truly sure if it will break the build without manual tests.

But I am totally fine with close this one!

@vkhoroz
Copy link
Member

vkhoroz commented Sep 25, 2023

@camilamacedo86 I think what you proposed to do is the correct way in general.
But, we have a plenty of work to do.

So, adding e2e tests for Fioctl should be prioritized first, as it requires a decent effort.
It is not equal to adding one test for one command out of hundreds.

Thanks for understanding and closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants