-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): Add linter improvements #272
Conversation
6715d9e
to
068c8d9
Compare
387bfb4
to
b05f151
Compare
@doanac I will leave it to you if you want to move these checks to Github Actions rather than our GavelCI 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It think this is the correct direction, and @doanac would probably agree.
But, please, make this in the least intrusive way.
@camilamacedo86 this is also conflicting with my PR #269. |
b05f151
to
3916f4f
Compare
Hi @vkhoroz, I addressed all suggestions as much as possible.
Could you please let me know where is the conflict? |
2bc068a
to
538f81a
Compare
404057f
to
d4774e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d4774e2
to
f182825
Compare
Signed-off-by: Camila Macedo <camila.macedo@foundries.io>
f182825
to
521c519
Compare
Description
This PR improves our linting process by:
##Motivation