Skip to content

Conversation

kprosise
Copy link
Contributor

@kprosise kprosise commented Apr 4, 2025

Admonition expanded with additional info.

QA: checked rendered output, edited with linter.

This commit addresses FFTK-1703, "Define what a Target is not"

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Admonition expanded with additional info.

QA: checked rendered output, edited with linter.

This commit addresses FFTK-1703, "Define what a Target is not"

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise requested review from vanmaegima and a team April 4, 2025 12:39
Copy link
Member

@vanmaegima vanmaegima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
just a comment, we in CS would like to propose more clarifications to this page based on other discussions we have, but this will come post v95 for sure

@kprosise kprosise merged commit cce99fb into foundriesio:main Apr 4, 2025
1 of 3 checks passed
@kprosise kprosise deleted the clarify-target branch April 4, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants