Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ug: introduce waves page #803
ug: introduce waves page #803
Changes from all commits
68ff6c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 68 in source/reference-manual/security/offline-keys.rst
Check warning on line 6 in source/user-guide/waves/waves.rst
Check warning on line 8 in source/user-guide/waves/waves.rst
Check warning on line 15 in source/user-guide/waves/waves.rst
Check warning on line 18 in source/user-guide/waves/waves.rst
Check warning on line 39 in source/user-guide/waves/waves.rst
Check warning on line 127 in source/user-guide/waves/waves.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more like a warning that needs to be specified separately, e.g. at the end of this section, wrapped into an actual warning block.
Check warning on line 131 in source/user-guide/waves/waves.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important information. This might need to be flagged or highlighted as a warning or some other mechanism to make it clear that key rotation impacts non completed waves pre v95.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these two bullets related? It is not evident from a text flow.
Is this also related to another bullet about v95? (Even less evident).
Anyway, I do agree with Tim that this deserves a separate attention and proper emphasize.
Does it make sense to grab all v95 related nuances into its own thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting to have all of this related to the v95 note, as this is the behavior customers are concerned with

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will add the v95 related nuances to the release notes page, so I though we could have a bigger warning there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This screenshot styling actually looks quite good.
If we can group all v95 related notes here similarly to how it was done in the release notes, that would be a reasonable improvement.
Check warning on line 138 in source/user-guide/waves/waves.rst
Check warning on line 168 in source/user-guide/waves/waves.rst