Skip to content

Add x86-64 note to clear up lack of details #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

kprosise
Copy link
Contributor

Added to the getting started guide under selecting platform.

QA Steps: Checked rendered html.

This commit addresses FFTK-2619

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

@kprosise kprosise requested review from angolini, ricardosalveti and a team July 21, 2023 11:28
@doanac
Copy link
Member

doanac commented Jul 21, 2023

Copy link
Member

@ricardosalveti ricardosalveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Added to the getting started guide under selecting platform.

QA Steps: Checked rendered html.

This commit addresses FFTK-2619

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
@kprosise kprosise force-pushed the clear-up-x86-qemu-confusion branch from 772c79b to f32a7ce Compare July 24, 2023 09:51
@doanac
Copy link
Member

doanac commented Jul 24, 2023

@kprosise kprosise merged commit f6b1968 into foundriesio:main Jul 25, 2023
@kprosise kprosise deleted the clear-up-x86-qemu-confusion branch July 25, 2023 10:54
kprosise added a commit to kprosise/docs that referenced this pull request Aug 1, 2023
Language was changed to note that the image is used by qemu rather than
with a qemu machine, per feedback on PR foundriesio#572

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
kprosise added a commit that referenced this pull request Aug 1, 2023
Language was changed to note that the image is used by qemu rather than
with a qemu machine, per feedback on PR #572

Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants