Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5b05809
fix(ui): remove logo hover effects in header
AlexVOiceover Nov 1, 2025
2364592
fix(ui): add zoom hover effect to header and footer icon buttons
AlexVOiceover Nov 1, 2025
2501516
fix(ui): make dashboard breadcrumb non-clickable when on dashboard page
AlexVOiceover Nov 1, 2025
18d2adb
fix(ui): add thicker border hover effect to dashboard tiles and quest…
AlexVOiceover Nov 1, 2025
558c818
fix(ui): improve action status terminology for clarity
AlexVOiceover Nov 1, 2025
9ae33f4
fix(ui): add page title and change OK button to Save
AlexVOiceover Nov 1, 2025
312874e
fix(ui): make email button reactive to visibility changes
AlexVOiceover Nov 1, 2025
95b7985
fix(ui): align email content and additional notes width
AlexVOiceover Nov 1, 2025
3380b91
fix(ui): match email preview layout to dashboard sections and move se…
AlexVOiceover Nov 1, 2025
e973e51
feat(branding): add LIFT organization favicon
AlexVOiceover Nov 1, 2025
cbcc236
fix(ui): add save confirmation message for response text (Issue #10)
AlexVOiceover Nov 1, 2025
f5401d5
fix(ui): improve visibility toggle text styling and clarity (Issue #11)
AlexVOiceover Nov 1, 2025
40bfdb3
fix(ui): remove saving state and fix mobile overlap in save status (I…
AlexVOiceover Nov 1, 2025
fbf6546
fix(types): add missing database service layer types and fix TypeScri…
AlexVOiceover Nov 1, 2025
4a803b1
fix(ui): remove hover effects from email preview and hide saved message
AlexVOiceover Nov 1, 2025
6e30f95
fix(ui): hide email button on email preview page
AlexVOiceover Nov 1, 2025
d2d7008
fix(content): replace ampersands with 'and' in user-facing text
AlexVOiceover Nov 1, 2025
444db02
fix(ui): remove italics and update manager actions field text
AlexVOiceover Nov 1, 2025
50e49a2
docs/updated report issues
AlexVOiceover Nov 1, 2025
52ebce7
refactor(ui): comment out back button in ViewHeader
AlexVOiceover Nov 1, 2025
21ad654
fix/added localhost as callback on config.toml
AlexVOiceover Nov 1, 2025
2fc55c5
chore: merge main into fix/testing-issues and resolve conflicts
AlexVOiceover Nov 1, 2025
950e960
fix(ui): convert all titles and buttons to sentence case and update a…
AlexVOiceover Nov 5, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,6 @@ docs/Brief_Docs/Test Script v1.49.
commit.md

# Pig
.pig/
.pig/

report.md
24 changes: 23 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,29 @@ When running locally, you can access:
- When prompted if you want to set up Edge Functions with Deno, answer "No"
- After initialization is complete, run `supabase start` again

7. **Docker Architecture Mismatch**
7. **Magic link authentication callback not working**

- If magic link emails are not including the `/auth/callback` redirect URL correctly, you may need to update the Supabase CLI

```bash
# Update Supabase CLI to latest version
npm install supabase@latest --save-dev

# Restart Supabase to apply config changes
supabase stop
supabase start
```

- Ensure your `supabase/config.toml` has the correct redirect URLs:

```toml
site_url = "http://127.0.0.1:5173"
additional_redirect_urls = ["http://127.0.0.1:5173/auth/callback","http://localhost:5173/auth/callback"]
```

- After updating the config or CLI, always restart Supabase for changes to take effect

8. **Docker Architecture Mismatch**

- If you see errors like `exec /usr/bin/sh: exec format error`, it means you're trying to run Docker containers built for a different CPU architecture

Expand Down
18 changes: 18 additions & 0 deletions docs/LIFT Workwise testing issue log.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
ID,Issue description,Page/section
1,The LIFT logo in the header should not have a hover effect and should not appear transluscent. ,Header
2,"The icons in these three buttons should turn pink when hovered: generate an email summary, get help, font size settings. Otherwise, they will disappear with a white hover background. ",All pages
3,"When on the dashboard page, 'Dashboard' in breadcrumb should be bold, not underlined, and not clickable, because it is the current page the user is on. ",Dashboard
4,Each button should have a hover effect. It can be thicker border. ,Dashboard
5,"The 'back' button should be on the left side of the breadcrumb, on the same line. ",All pages
6,"It is not intuitive to use 'active' and 'inactive' to describe actions. Using 'to do' and 'done' should be clearer. So the toggle module can be: [Link button] To do [toggle] Done. At the same time, the 'Show Inactive' toggle at the top should change to 'Show done actions'.",Actions
8,The website should have a proper page title as displayed in the browser tab. ,All pages
9,The OK button should have text 'Save' instead. ,All forms
10,"After editing and saving a field, there should be a confirmation message to let users know the changes have been saved. ",All forms
11,This line of text should be black instead of grey and it misses a full stop: 'Visibility to employer. This answer and actions will be included on the email',All forms
12,"When switching the 'Visibility to employer' toggle on mobile, 'Saved' message overlaps with section heading. ",All forms
13,"When sending an email to the manager, in the email preview, actions fields should not have hover effect as they are not editable. ",Email Preview
14,"On the email preview page, the email button at the top-right corner in the header should not be transluscent. It should be removed on this page. ",Email Preview
17,Please replace all ampersands with 'and' in full,All pages
18,Remove all use of italics across the site,All pages
20,Change the field on manager actions to 'The actions you'd like your manager to take in response to this question.',All forms
21,"In My workplace adjustments, it says 'What do you need to thrive in your role here at Islington?' Is this right, at Islington suggest the council when this is for wider use and I guess this will be available to the other LIFT boroughs? ",My workplace adjustments
192 changes: 192 additions & 0 deletions docs/TESTING_ISSUES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,192 @@
# LIFT Workwise Testing Issue Log

Track testing issues and their resolution status. Work through these one by one, committing after each fix.

## Issues

### Issue #1 - Logo hover effect
- [x] **Status**: ✅ Fixed
- **Description**: The LIFT logo in the header should not have a hover effect and should not appear translucent.
- **Location**: Header
- **Files affected**: `src/lib/components/layouts/Header.svelte` (line 116)
- **Solution**: Removed `hover:opacity-80`, `transition-opacity`, and `cursor-pointer` classes from logo button

---

### Issue #2 - Icon hover effects
- [x] **Status**: ✅ Fixed
- **Description**: The icons in these four buttons should have a visible hover effect: generate an email summary, get help, font size settings, profile settings. Previously they had a white background that made icons disappear.
- **Location**: All pages (header and footer)
- **Files affected**:
- `src/lib/components/layouts/Header.svelte` (email button - line 161, 169)
- `src/lib/components/ui/HelpButton.svelte` (help button - line 92)
- `src/lib/components/ui/FontSizeControl.svelte` (font size button - line 98, 102)
- `src/lib/components/ui/ProfileButton.svelte` (profile button - line 28, 32)
- **Solution**: Removed white background hover effect and added 25% scale zoom on icon/text only (not border) using `transition-transform hover:scale-125` and `group-hover:scale-125`

---

### Issue #3 - Dashboard breadcrumb styling
- [x] **Status**: ✅ Fixed
- **Description**: When on the dashboard page, 'Dashboard' in breadcrumb should be bold, not underlined, and not clickable, because it is the current page the user is on.
- **Location**: Dashboard
- **Files affected**: `src/lib/components/ui/Breadcrumb.svelte` (line 105-109)
- **Solution**: Changed Dashboard breadcrumb item to be non-clickable (`clickable: false`) when current view is dashboard. The existing CSS already styles non-clickable items as bold without underline using `.breadcrumb-current` class.

---

### Issue #4 - Button hover effects
- [x] **Status**: ✅ Fixed
- **Description**: Each button should have a hover effect. It can be thicker border.
- **Location**: Dashboard and question lists
- **Files affected**: `src/app.css` (lines 89-91, 106, 353)
- **Solution**: Added inset box-shadow on hover to create a thicker border effect that grows inward (doesn't affect layout). Applied to:
- `.dash-tile-rect` (2px inset)
- `.dash-tile-square` (2px inset combined with existing shadow)
- `.list-item-questions` (2px inset combined with existing shadow)

---

### Issue #5 - Back button position
- [ ] **Status**: ❌ Not implemented - breaks layout
- **Description**: The 'back' button should be on the left side of the breadcrumb, on the same line. Remove the icon, only text "back"
- **Location**: All pages
- **Files affected**: N/A
- **Reason not implemented**: Moving the back button to the left side of the breadcrumb breaks all the style logic. The current grid layout has the breadcrumb on the left and back button on the right, which is intentional for the overall design system.

---

### Issue #6 - Action status terminology
- [x] **Status**: ✅ Fixed
- **Description**: It is not intuitive to use 'active' and 'inactive' to describe actions. Using 'to do' and 'done' should be clearer. So the toggle module can be: [Link button] To do [toggle] Done. At the same time, the 'Show Inactive' toggle at the top should change to 'Show done actions'.
- **Location**: Actions
- **Files affected**:
- `src/lib/components/ui/ActionStatusToggle.svelte` (lines 17, 24)
- `src/lib/components/ui/ShowArchivedToggle.svelte` (line 14)
- **Solution**: Added static labels "To do" and "Done" on either side of the toggle switch. Changed "Show Inactive" to "Show done actions" in the filter toggle. Layout: [Link button] To do [toggle] Done

---

### Issue #8 - Page title
- [x] **Status**: ✅ Fixed
- **Description**: The website should have a proper page title as displayed in the browser tab.
- **Location**: All pages
- **Files affected**: `src/app.html` (line 7)
- **Solution**: Added `<title>LIFT Workwise</title>` to the HTML head in app.html

---

### Issue #9 - Save button text
- [x] **Status**: ✅ Fixed
- **Description**: The OK button should have text 'Save' instead.
- **Location**: All forms
- **Files affected**: `src/lib/components/cards/QuestionCard.svelte` (lines 239, 310)
- **Solution**: Changed button text from "OK" to "Save" in QuestionCard component. Also updated comment reference to "Save button".

---

### Issue #10 - Save confirmation
- [x] **Status**: ✅ Fixed
- **Description**: After editing and saving a field, there should be a confirmation message to let users know the changes have been saved.
- **Location**: All forms
- **Files affected**: `src/lib/components/cards/QuestionCard.svelte` (lines 105, 232, 329-331)
- **Solution**: Added `saveSuccess` state that shows "Saved" message for 2 seconds after successfully saving response text. Message appears inline next to Save/Undo buttons in green text.

---

### Issue #11 - Visibility text styling
- [x] **Status**: ✅ Fixed
- **Description**: This line of text should be black instead of grey and it misses a full stop: 'Visibility to employer. This answer and actions will be included on the email'
- **Location**: All forms
- **Files affected**: `src/lib/components/ui/ToggleStatus.svelte` (line 16-17)
- **Solution**: Added `text-base-content` class to make text black instead of grey, and added full stop at end of sentence

---

### Issue #12 - Mobile saved message overlap
- [x] **Status**: ✅ Fixed
- **Description**: When switching the 'Visibility to employer' toggle on mobile, 'Saved' message overlaps with section heading.
- **Location**: All forms
- **Files affected**: `src/lib/components/ui/SaveStatus.svelte` (lines 9-22), `src/lib/components/cards/QuestionCard.svelte` (line 286, 293)
- **Solution**: Removed "Saving..." state to eliminate visual flicker. Added `pr-16` padding to heading to reserve space for "Saved" message. Added `z-10` to ensure message appears above heading on mobile.

---

### Issue #13 - Email preview hover effects
- [x] **Status**: ✅ Fixed
- **Description**: When sending an email to the manager, in the email preview, actions fields should not have hover effect as they are not editable.
- **Location**: Email Preview
- **Files affected**: `src/app.css` (lines 538-542)
- **Solution**: Added CSS rule to remove hover effects from `.action-item` elements within `#email-content`, setting `hover:shadow-none` and `cursor: default`

---

### Issue #14 - Email button on email preview
- [x] **Status**: ✅ Fixed
- **Description**: On the email preview page, the email button at the top-right corner in the header should not be translucent. It should be removed on this page.
- **Location**: Email Preview
- **Files affected**: `src/lib/components/layouts/Header.svelte` (line 148)
- **Solution**: Added `!isInEmailView` condition to the email button's `{#if}` block to completely hide it when viewing email preview, and removed `isInEmailView` from the `isDisabled` logic since button is now hidden

---

### Issue #17 - Replace ampersands
- [x] **Status**: ✅ Fixed
- **Description**: Please replace all ampersands with 'and' in full
- **Location**: All pages
- **Files affected**: `src/lib/components/cards/QuestionCard.svelte` (lines 267, 342)
- **Solution**: Replaced "Delete Response & Actions" with "Delete Response and Actions" in both the modal title and button text

---

### Issue #18 - Remove italics
- [x] **Status**: ✅ Fixed
- **Description**: Remove all use of italics across the site
- **Location**: All pages
- **Files affected**:
- `src/app.css` (line 321)
- `src/lib/components/ui/FontSizeControl.svelte` (line 107)
- `src/lib/components/ui/HelpModal.svelte` (line 85)
- **Solution**: Removed `italic` class/styling from action question preview text, font size control icon, and help modal screenshot captions

---

### Issue #16 - Sentence case for all titles and buttons
- [x] **Status**: ✅ Fixed
- **Description**: Please make all titles sentence case rather than title case. This includes buttons e.g. 'Select Test User' should be 'Select test user'
- **Location**: All pages
- **Files affected**:
- `src/lib/components/ui/ProfileCompletionModal.svelte` (lines 64, 73, 89, 104, 128)
- `src/lib/components/ui/ProfileSettingsModal.svelte` (lines 96, 102, 132, 147, 189)
- `src/lib/components/ui/ActionsCRUD.svelte` (lines 195, 307, 333)
- `src/lib/components/cards/QuestionCard.svelte` (lines 267, 342)
- `src/lib/components/views/Email.svelte` (lines 70, 80, 108)
- `src/lib/components/views/Dash.svelte` (lines 52, 61, 68, 74, 77, 130, 139, 143, 148)
- `src/lib/components/ui/FontSizeControl.svelte` (lines 25, 29, 125)
- `src/lib/components/views/Detail.svelte` (line 30)
- `src/lib/components/layouts/Header.svelte` (line 162)
- **Solution**: Converted all modal titles, button labels, form field labels, loading messages, and navigation labels from Title Case to sentence case throughout the application

---

### Issue #20 - Manager actions field text
- [x] **Status**: Not started
- **Description**: Change the field on manager actions to 'The actions you'd like your manager to take in response to this question.'
- **Location**: All forms
- **Files affected**: TBD

---

### Issue #21 - "Islington" reference
- [ ] **Status**: Not started
- **Description**: In My workplace adjustments, it says 'What do you need to thrive in your role here at Islington?' Is this right, at Islington suggest the council when this is for wider use and I guess this will be available to the other LIFT boroughs?
- **Location**: My workplace adjustments
- **Files affected**: TBD

---

## Progress Summary

- **Total Issues**: 17
- **Completed**: 7
- **Remaining**: 9 (2 rejected - Issue 5, issue 21)
Loading