Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for <h-line> #106

Closed
pilaf opened this issue Dec 6, 2021 · 2 comments
Closed

Missing support for <h-line> #106

pilaf opened this issue Dec 6, 2021 · 2 comments

Comments

@pilaf
Copy link

pilaf commented Dec 6, 2021

Hello, I noticed that inky-rb is lacking support for <h-line> (unlike https://github.com/foundation/inky).

(Thank you for this great tool!)
@marcandre
Copy link
Collaborator

Interesting. Do you actually use <h-line>? It seems to be completely broken on inky, or am I missing something.

In any case I'll implement it.

marcandre added a commit that referenced this issue Dec 6, 2021
@marcandre
Implement <h-line> [Fixes #106]
35d1b53 
Note: original inky's implementation seems completely broken
foundation/inky#137
foundation/inky#136
@marcandre marcandre mentioned this issue Dec 6, 2021
Merged
marcandre added a commit that referenced this issue Dec 6, 2021
@marcandre
Implement <h-line> [Fixes #106]
b1305b1 
Note: original inky's implementation seems completely broken
foundation/inky#137
foundation/inky#136
@marcandre
Copy link
Collaborator

Released v1.4.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcandre @pilaf