Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: OffCanvas correct transition time details #11667

Conversation

noahheck
Copy link
Contributor

Description

Because transitionTime is passed directly to the element CSS, the value should include the appropriate units. This PR updates the auto-generated documentation for this.
...

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncoden
Copy link
Contributor

ncoden commented Jan 27, 2019

Hi @noahheck 👋, thank you for your pull request!
Your fix is compatible with the in-development version of Foundation. Could you rebase your stuff on develop ?

git checkout docs/offcanvas-correct-transition-time-details
git rebase develop

Then force-push and change the base of your pull request to develop. Thank you!

@noahheck noahheck force-pushed the docs/offcanvas-correct-transition-time-details branch from 5cd58f6 to 16c8532 Compare January 28, 2019 00:06
@noahheck noahheck changed the base branch from develop-v6.5 to develop January 28, 2019 00:07
Because `transitionTime` is passed directly to the element CSS, the value should include the appropriate units
@noahheck noahheck force-pushed the docs/offcanvas-correct-transition-time-details branch from 16c8532 to a3efc98 Compare January 28, 2019 00:14
@noahheck
Copy link
Contributor Author

Hi @ncoden! I hope everything looks correct at this point. The rebase didn't quite work how I would have liked, so I simply recreated the change off of an up-to-date develop branch. Please let me know if you need anything else!

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you @noahheck

@ncoden ncoden merged commit 80cc570 into foundation:develop Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OffCanvas transition-time value incorrectly listed as number instead of string
3 participants