Fix wrong implementation of horizontal centering the grid-container #11634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The margin on top and bottom of the container should not be set to ZERO. And vertical margin on the grid-container makes it impossible to add a new margin top or bottom. Should not be set by default.
KevinKoobs
approved these changes
Dec 17, 2018
ncoden
approved these changes
Dec 18, 2018
There was a problem hiding this comment.
Hi @HarwinBorger 👋, thank you for the pull request.
You are right. Even if it is easier to use the short-hand property margin, we should not set the vertical/horizontal margin when it is not needed.
So XY Grid container is an horizontal container only. So LGTM 👍
Thamks @KevinKoobs for the review.
|
Hi @ncoden, Thanks for the quick response. I am happy to hear that you approve the changes. Looking forward to the next update! 👍 |
ncoden
pushed a commit
that referenced
this pull request
Jan 11, 2019
…alue for v6.5.0 2b71513 Fix wrong implementation of centering the grid-container Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The margin on top and bottom of the container should not be set to ZERO. And vertical margin on the grid-container makes it impossible to add a new margin top or bottom. Should not be set by default.
Types of changes
Checklist
developordevelop-v...).