Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigate multinicnetwork reconcile #170

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

sunya-ch
Copy link
Collaborator

@sunya-ch sunya-ch commented Jan 11, 2024

This PR patch is to remove unnecessary reconcile over multinicnetwork which comes from several causes

  • netconfig status updates last-sync time
  • NAD creation error on some namespaces
  • non-MultiNicIPAM false negative error

Before:

 LEVEL(-2) Failed to manage multi-nic-network: non-MultiNicIPAM
--> reconcile multinicnetwork next few seconds

After:

LEVEL(-3) Update multi-nic-network status (Non-MultiNICIPAM, RouteNoApplied)

Signed-off-by: Sunyanan Choochotkaew sunyanan.choochotkaew1@ibm.com

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@sunya-ch sunya-ch merged commit 5762020 into foundation-model-stack:v1.2.0 Jan 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant