Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ibm-fms install for mypy #10

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

afrittoli
Copy link
Collaborator

@afrittoli afrittoli commented Feb 16, 2024

Install ibm-fms with -I, to ignore the version pre-installed, so that the package is installed from the main branch, which includes the py.typed file required for mypy testing.

@afrittoli afrittoli force-pushed the install_fms_dev branch 2 times, most recently from 207d87b to 42085df Compare February 16, 2024 11:12
@afrittoli afrittoli marked this pull request as draft February 16, 2024 11:17
@afrittoli afrittoli force-pushed the install_fms_dev branch 7 times, most recently from 6e55223 to d8bc8cd Compare February 16, 2024 16:55
@afrittoli afrittoli marked this pull request as ready for review February 16, 2024 16:55
@afrittoli afrittoli marked this pull request as draft February 16, 2024 16:58
Install ibm-fms with -I so that the package is installed
from the main branch, which includes the py.typed file required
for mypy testing.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@afrittoli afrittoli marked this pull request as ready for review February 16, 2024 17:18
@nairbv nairbv merged commit 118e2ee into foundation-model-stack:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants