-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExpertParallel Mixture-of-Experts Plugin #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
force-pushed
the
refactor/moe
branch
from
November 3, 2024 09:10
0759fac
to
6d1e646
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
force-pushed
the
refactor/moe
branch
from
November 3, 2024 15:05
b45fdda
to
4e9bfa0
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
force-pushed
the
refactor/moe
branch
3 times, most recently
from
November 5, 2024 01:52
f412899
to
bccd967
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
force-pushed
the
refactor/moe
branch
from
November 6, 2024 10:03
bccd967
to
7ae52ce
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
force-pushed
the
refactor/moe
branch
from
November 8, 2024 12:48
cb8416d
to
1d6a42b
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
force-pushed
the
refactor/moe
branch
from
November 11, 2024 08:05
1d6a42b
to
005300b
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
fabianlim
force-pushed
the
refactor/moe
branch
from
November 11, 2024 15:02
21af5fb
to
d3fb653
Compare
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
Signed-off-by: Yu Chin Fabian Lim <flim@sg.ibm.com>
7 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will supercede #69.
This PR will add a new
accelerated-moe
plugin that is triton-onlyTODO:
Performance
For
ibm-granite/granite-3.0-3b-a800m-instruct
andMixtral-8x7B-Instruct-v0.1
bfloat16
no mixed precisionframework_config = None
: FSDPmoe-scattermoe-granite-ep1
: MoE world_size = 1moe-scattermoe-granite-ep2
: MoE world_size = 2Resumption
non-sharded checkpoints: Tested resumption on 2 devices for expert size 1 and 2
Also for sharded checkpoints (mixtral): tested resumption
Handling the State Dict
we have a convinience function
restore_scattermoe_checkpoint_to_orig
to load the DCP checkpoint, and optionally convert back to original if the pretrained checkpoint is provided.