Fix Bug on Peft Config Check in AutoGPTQ Plugin #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix to address a mistake with a check on
target_modules
in peft_config. Target modules come in as aset
and the assertion will be raised unnecessarily.mistake:
assert isinstance(tm, (list, str)), "target modules can only be list or string"
correction:
assert isinstance(tm, (list, set, str)), "target modules can only be list, set or string"
Tested with alpaca on both
all-linear
andq_proj k_proj v_proj o_proj
all-linear
q_proj k_proj v_proj o_proj