Skip to content

Options on associations should be respected #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Options on associations should be respected #132

wants to merge 1 commit into from

Conversation

lewisf
Copy link

@lewisf lewisf commented May 27, 2020

Please let me know if this makes sense and anything else I would need to do.

I mostly did this to support

  has_many :related_objects, include_data: true, serializer: MyCustomSerializer

Where I wanted to override the Serializer in the case where related_objects is a list of ActiveRecord STI objects but I wanted to use a single serializer for all of them.

Was it intentional that related objects use top level options (@options) and ignore inline options when using find_serializer?

@lewisf lewisf changed the title Related objects should respect serializer options Options on associations should be respected May 27, 2020
@persona-id persona-id closed this by deleting the head repository Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants