Add Instrumentation Support with ActiveSupport::Notifications #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones
commented
Nov 13, 2019
| @@ -24,4 +24,5 @@ Gem::Specification.new do |spec| | |||
| spec.add_development_dependency "rspec", "~> 3.2" | |||
| spec.add_development_dependency "factory_girl", "~> 4.5" | |||
| spec.add_development_dependency "activemodel", "~> 4.2" | |||
| spec.add_development_dependency "pry" | |||
There was a problem hiding this comment.
can remove if you want but it was nice to have.
djones
commented
Nov 13, 2019
| @@ -16,6 +17,7 @@ def serialize_primary(object, options = {}) | |||
| primary_data = serialize_primary(nil, {serializer: MyApp::PostSerializer}) | |||
| expect(primary_data).to be_nil | |||
| end | |||
|
|
|||
fotinakis
approved these changes
Nov 19, 2019
|
released in jsonapi-serializers (2.0.0.pre.beta.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ActiveSupport::Notifications this PR allows you to subscribe to key notifications to better understand the performance of your serialization.
The following notifications can be subscribed to:
render.jsonapi_serializers.serialize_primary- time spent serializing a single objectrender.jsonapi_serializers.find_recursive_relationships- time spent finding objects to serialize through relationshipsThis is an example of how you might subscribe to all events that come from
jsonapi-serializers.