Skip to content

Fix warnings from ruby 2.4.2 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix warnings from ruby 2.4.2 #113

wants to merge 1 commit into from

Conversation

dcoxall
Copy link

@dcoxall dcoxall commented Nov 20, 2017

This prevents warnings when accessing initialized instance variables and a warning when redefining the base_url method (attr_accessor defined a reader and then we later define another)

@utilum
Copy link

utilum commented Nov 22, 2017

  1. This is actually related to when you turn on warnings, not to Ruby 2.4.2. Warnings are on by by default when you launch a rake task since Rake 11.0.0. However, even with Rake 12, the current test suite passes without warnings about instance variable not initialized... May want to add tests for your chnages.

@fotinakis fotinakis closed this May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants