Skip to content

Fix workflow waring message #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,27 +83,24 @@ jobs:
- uses: actions/checkout@v3
with:
ref: main
- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.12'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install .
pip install pyinstaller==5.9.0
pip install pyinstaller
- name: Build with pyinstaller for ${{matrix.TARGET}}
run: ${{matrix.CMD_BUILD}}
- name: Upload Release Asset
id: upload-release-asset
uses: actions/upload-release-asset@v1.0.1
uses: softprops/action-gh-release@v1
env:
GITHUB_TOKEN: ${{ secrets.TOKEN }}
with:
upload_url: ${{ github.event.release.upload_url }}
asset_path: ./${{ matrix.OUT_FILE_NAME}}
asset_name: ${{ matrix.OUT_FILE_NAME}}
asset_content_type: ${{ matrix.ASSET_MIME}}
deploy:
runs-on: ubuntu-latest
needs: build
Expand All @@ -114,7 +111,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.12'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8]
python-version: [3.12.x]

steps:
- uses: actions/checkout@v3
Expand All @@ -37,13 +37,13 @@ jobs:
runs-on: windows-latest
strategy:
matrix:
python-version: [3.8]
python-version: [3.12.x]
steps:
- uses: actions/checkout@v3
- name: Set up Python 3.8
- name: Set up Python 3.12
uses: actions/setup-python@v4
with:
python-version: '3.8'
python-version: '3.12.x'
- name: Install & Run
run: |
python -m pip install --upgrade pip
Expand Down
4 changes: 2 additions & 2 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pyinstaller==5.9.0
pyinstaller>=6.0.0
tox
pytest
pytest-cov
pytest-flake8
pytest-xdist
flake8==3.9.2
flake8
1 change: 0 additions & 1 deletion src/fosslight_binary/_binary_dao.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ def get_list_by_using_query(sql_query, columns):


def disconnect_lge_bin_db():
global conn, cur
try:
cur.close()
conn.close()
Expand Down
1 change: 0 additions & 1 deletion src/fosslight_binary/binary_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ def check_binary(file_with_path):


def error_occured(error_msg, exit=False, result_log={}, mode="Normal mode"):
global _error_logs
_error_logs.append(error_msg)
if exit:
print_result_log(mode, success=False, result_log=result_log)
Expand Down
1 change: 0 additions & 1 deletion src/fosslight_binary/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def paginate_file(file_path):


def main():
global windows
path_to_find_bin = ""
path_to_exclude = []
output_dir = ""
Expand Down