fix: Connect smart speaker to open wifi #2263

atm1504 · 2019-06-13T15:35:32Z

Changes:
Fixed the error that prevented the app to connect the smart speaker to open wifi.
Now users can connect to open wifi simply by clicking next in the wifi password prompt.

Screenshots for the change:

atm1504 · 2019-06-13T16:29:39Z

Apk: https://drive.google.com/file/d/1-40PxYAb0gbM6o_VOJJpXdPHh6_BqKxL/view?usp=drivesdk

norbusan · 2019-06-14T03:01:49Z

I asked for access via my gmail account to the apk, thanks

atm1504 · 2019-06-14T04:02:19Z

I asked for access via my gmail account to the apk, thanks

I have updated the link. Please check now. It won't ask for permission. Sorry for the inconvenience caused.

atm1504 · 2019-06-14T07:38:07Z

Apk:
app-fdroid-debug.apk.zip

norbusan · 2019-06-14T08:49:07Z

@atm1504 same with the .apk from the zip. I unzipped it, downloaded it via dropbox to my phone, and tried to install it using x-plore (fs manager, I use often for isntalling apks).

This is Android 9, Huawei Mate 10 Pro.

iamareebjamal · 2019-06-14T10:02:03Z

@norbusan What failed while installing?

norbusan · 2019-06-14T15:20:10Z

@iamareebjamal How can I know? It starts installing, and then sqitches to a screen "Installation has failed" ...

iamareebjamal · 2019-06-14T23:07:24Z

@atm1504 Have you given unsigned APK?

atm1504 · 2019-06-15T05:28:27Z

@atm1504 Have you given unsigned APK?

No

norbusan · 2019-06-15T05:46:16Z

Hmmm, strange. Any tip how one can debug that?

atm1504 · 2019-06-15T05:47:46Z

Can you please try out a different package installer other than the one you are using now. : )

norbusan · 2019-06-15T05:58:33Z

Re-downloaded the zip, tried with Huawei's "Files", and then again with Firefox downloader ... all with the same effect.

iamareebjamal · 2019-06-15T07:08:06Z

@atm1504 Come on, there is a single package manager on Android, there is no other option. You've got to know that

Did you download and try installing yourself?

atm1504 · 2019-06-15T18:40:30Z

@atm1504 Come on, there is a single package manager on Android, there is no other option. You've got to know that

Did you download and try installing yourself?

Yes, I did so. It worked fine in both of the devices that I used.

ci-reporter · 2019-06-17T06:20:44Z

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 75ce24f. Here's the output:

`Run Tests`

> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for c3cac80

`Run Tests`

> Task :app:preBuild UP-TO-DATE

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

ci-reporter · 2019-06-17T06:20:44Z

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of c3cac80. Here's the output:

`Run Tests`

> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

iamareebjamal

If you are suffering from fever, the doctor doesn't kill you to end the disease

iamareebjamal · 2019-06-18T15:54:52Z

The change in this PR has no relation to the issue it is solving

atm1504 · 2019-06-18T16:01:51Z

The change in this PR has no relation to the issue it is solving

I debugged the code. The error was mentioning about failing to connect because of clear text communication. Google search reveals that it occurs because of local connections. And we cannot use https in local, we always have http. To overcome this error, we need to take a special permission in manifest. That is what I added. Also, I faced similar issue in an app of my college and solved that in the same way. The app works on intranet of campus (http connection?)

iamareebjamal · 2019-06-18T16:12:54Z

The error you mentioned only happens on P+ Android devices. Is it working on lower versions.

Secondly, the solution is to whitelist IPs and not allow cleartext communication by default

atm1504 · 2019-06-18T16:21:56Z

The error you mentioned only happens on P+ Android devices. Is it working on lower versions.

Secondly, the solution is to whitelist IPs and not allow cleartext communication by default

I did found the error in oreo also.

Okk, so u mean what i should do is that only allow those particular ip's to have clear text communication, rather then allowing all.

atm1504 · 2019-06-19T07:08:16Z

@iamareebjamal @batbrain7 @arundhati24 please review it.

iamareebjamal · 2019-06-19T07:13:46Z

app/src/main/res/xml/network_security_config.xml

+    <domain-config cleartextTrafficPermitted="true">
+        <domain includeSubdomains="true">10.0.0.1:5000</domain>
+        <domain includeSubdomains="true">ipinfo.io</domain>
+        <domain includeSubdomains="true">api.duckduckgo.com</domain>


Remove last 2, replace with https

iamareebjamal · 2019-06-19T11:34:41Z

Have you now verified that it is working?

atm1504 · 2019-06-19T12:21:12Z

Apk: app-fdroid-debug.apk.zip

@iamareebjamal I have tested this apk, after the change, it's working now.

atm1504 · 2019-06-20T15:27:03Z

@iamareebjamal @batbrain7 @arundhati24 please review it. I cannot move further with pr #2267 until this is merged. : )

fix: Connect smart speaker to open wifi

ae97c0f

auto-label bot added the fix label Jun 13, 2019

Merge branch 'development' into atm_open_wifi_connect

0c9db73

Merge branch 'development' into atm_open_wifi_connect

3ea2f3a

atm1504 mentioned this pull request Jun 17, 2019

Communication to ipinfo.io is not permitted by network policy #2268

Closed

trigger circle ci

c3cac80

re trigger circle ci

5cb3d47

iamareebjamal requested changes Jun 18, 2019

View reviewed changes

iamareebjamal closed this Jun 18, 2019

iamareebjamal reopened this Jun 18, 2019

atm1504 added 2 commits June 19, 2019 12:06

Merge branch 'development' into atm_open_wifi_connect

549cf0c

fix: Add network permit file

cd43b56

atm1504 mentioned this pull request Jun 19, 2019

Communication to api.duckduckgo.com is not permitted by network policy #2272

Closed

iamareebjamal reviewed Jun 19, 2019

View reviewed changes

atm1504 added 2 commits June 19, 2019 12:45

Remove other links

def76f2

trigger circle ci

98925ca

atm1504 added 2 commits June 19, 2019 17:47

fix minor url issue

7cadf20

Merge branch 'development' into atm_open_wifi_connect

b99c1c1

Merge branch 'development' into atm_open_wifi_connect

11baf31

atm1504 mentioned this pull request Jun 20, 2019

feat: Add room feature #2267

Merged

iamareebjamal approved these changes Jun 20, 2019

View reviewed changes

iamareebjamal merged commit 6fe2e14 into fossasia:development Jun 20, 2019

fix: Connect smart speaker to open wifi #2263

fix: Connect smart speaker to open wifi #2263

Uh oh!

Conversation

atm1504 commented Jun 13, 2019 • edited by iamareebjamal Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atm1504 commented Jun 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

norbusan commented Jun 14, 2019

Uh oh!

atm1504 commented Jun 14, 2019

Uh oh!

atm1504 commented Jun 14, 2019

Uh oh!

norbusan commented Jun 14, 2019

Uh oh!

iamareebjamal commented Jun 14, 2019

Uh oh!

norbusan commented Jun 14, 2019

Uh oh!

iamareebjamal commented Jun 14, 2019

Uh oh!

atm1504 commented Jun 15, 2019

Uh oh!

norbusan commented Jun 15, 2019

Uh oh!

atm1504 commented Jun 15, 2019

Uh oh!

norbusan commented Jun 15, 2019

Uh oh!

iamareebjamal commented Jun 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atm1504 commented Jun 15, 2019

Uh oh!

ci-reporter bot commented Jun 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The build is failing

Run Tests

Run Tests

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

Uh oh!

ci-reporter bot commented Jun 17, 2019

The build is failing

Run Tests

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

Uh oh!

iamareebjamal left a comment

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Jun 18, 2019

Uh oh!

atm1504 commented Jun 18, 2019

Uh oh!

iamareebjamal commented Jun 18, 2019

Uh oh!

atm1504 commented Jun 18, 2019

Uh oh!

atm1504 commented Jun 19, 2019

Uh oh!

iamareebjamal Jun 19, 2019

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Jun 19, 2019

Uh oh!

atm1504 commented Jun 19, 2019

Uh oh!

atm1504 commented Jun 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

atm1504 commented Jun 13, 2019 •

edited by iamareebjamal

Loading

atm1504 commented Jun 13, 2019 •

edited

Loading

iamareebjamal commented Jun 15, 2019 •

edited

Loading

ci-reporter bot commented Jun 17, 2019 •

edited

Loading

`Run Tests`

`Run Tests`

`Run Tests`