-
Notifications
You must be signed in to change notification settings - Fork 87
repoList closing properly now #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
Reviewer's GuideImprove repo filter behavior by ensuring the filter UI closes and hideDropdown is invoked when no token is present, and auto-hide the token warning after a brief delay. Sequence diagram for repo filter closing when no token is presentsequenceDiagram
actor User
participant UI as Repo Filter UI
participant Storage as chrome.storage.local
participant Dropdown as hideDropdown()
User->>UI: Enable repo filter
UI->>UI: Check for GitHub token
alt No token present
UI->>UI: Uncheck repo filter
UI->>UI: Hide repo filter container
UI->>Dropdown: Call hideDropdown()
UI->>Storage: Set useRepoFilter to false
UI->>UI: Show token warning
UI->>UI: Auto-hide warning after 4s
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes - here's some feedback:
- The hide repoFilterContainer and hideDropdown logic is duplicated in multiple places — extract into a helper to keep the behavior consistent.
- repoFilterContainer is only queried in the first block, so it’s undefined in the later listener; move its selection into a shared scope or re-select it where needed.
- Consider clearing any existing tokenWarning timeout before setting a new setTimeout to prevent overlapping hides if the user toggles the filter rapidly.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The hide repoFilterContainer and hideDropdown logic is duplicated in multiple places — extract into a helper to keep the behavior consistent.
- repoFilterContainer is only queried in the first block, so it’s undefined in the later listener; move its selection into a shared scope or re-select it where needed.
- Consider clearing any existing tokenWarning timeout before setting a new setTimeout to prevent overlapping hides if the user toggles the filter rapidly.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
@Preeti9764 please test this |
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
@vedansh-5 i found it is showing 3 repos for last one day please look into this and this is in master branch also please resolve this repo filter bug as it shows last stored repos no. and doesn't shows repos on basis of date selected now, as you have applied gets updated on switching the date ranges.Thanks! repo.bug.mp4 |
This is not a bug, Preeti. You disabled the checkbox before changing the dates - that means the new repo list won’t be fetched when dates are changed because the feature is disabled. This is the intended behavior - we do not want unnecessary fetch requests when the extension is turned off, especially if there’s no token. |
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
📌 Fixes
Fixes # (Use "Fixes", "Closes", or "Resolves" for automatic closing)
📝 Summary of Changes
Repo List closes properly now
📸 Screenshots / Demo (if UI-related)
repoList.mp4
✅ Checklist
👀 Reviewer Notes
Add any special notes for the reviewer here
Summary by Sourcery
Ensure the repository filter UI properly hides and the dropdown closes when toggled without a GitHub token, and auto-dismiss the token warning after a delay.
Bug Fixes: