fix: Export components with formStyles correctly #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Oscilloscope ChannelParameters and the Waveform SineWaveParameters have both a global style, and a local style they need to be exported with. The use of the withStyles function was previously incorrect, and as a result, neither style was getting applied.
orangecms
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Oscilloscope ChannelParameters and the Waveform SineWaveParameters have
both a global style, and a local style they need to be exported with. The use
of the withStyles function was previously incorrect, and as a result, neither
style was getting applied.
Please check if the PR fulfills these requirements
I reworked the way
withStyleswas called to function correctly. Before we were trying to create an object containing the spread of two functions. Trying to spread a function will result in an error and the resulting object will benull. The changes fix this issue while maintaining the desired behavior of both styles applying.fixes #682
Does this PR introduce a breaking change?
No
Preview / Steps to verify your work:
Style is now beautifully applied.