Feat (Logic Analyzer): Auto Recapture and Capture Time slider #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture time slider is changed to allow for larger values and more fine-tuned control. Auto Recapture checkbox added to have the logic analyzer continously recapture until an event is detected. The Graph component is recieving the LA data and if a capture has no event within it and the auto recapture is on, the LA is toggled back on. Standarized UI to use μs which is converted to ms for the backend communication. Fix (Logic Analyzer): Define inputCheck The CustomDialog dispatch needs an inputCheck function to be defined. The Logic Analyzer capture time slider will always be an non-negative float so inputCheck will check for that.
cynthi8
force-pushed
the
logic-analyzer-fix
branch
from
ffe4a3b to
8f86b9d
Compare
orangecms
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture time slider is changed to allow for larger values and more
fine-tuned control. Auto Recapture checkbox added to have the logic
analyzer continuously recapture until an event is detected.
The Graph component is receiving the LA data and if a capture has no
event within it and the auto recapture is on, the LA is toggled
back on.
Standarized UI to use μs which is converted to ms for the backend communication.
Fix (Logic Analyzer): Define inputCheck
The CustomDialog dispatch needs an inputCheck function to be defined.
The Logic Analyzer capture time slider will always be an
non-negative float so inputCheck will check for that.
No tests or docs were added. Do we have a unit test framework for UI elements that need parts of the App to function (and thus can't be used in Storybook)?
Where should I add new functionality documentation?
Fixes #665
Fixed. X axis and capture time are μs. Capture time is converted to ms to work with the logic analyzer configuration backend.
Fixed. Dialog input works and range is extended to up to a second (1000000 μs)
Added. Auto recapture checkbox will retrigger the LA if no events were captured.
Does this PR introduce a breaking change?
No
Preview / Steps to verify your work:
Logic Analyzer is functional, capture time slider and dialog options work. Auto recapture functionality works.
Screenshot of UI:
