feat: Add cross-env to project scripts #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cross-env allows Windows users to run npm scripts that set enviromental variables. Single quotes were also replaced with escaped double quotes for Windows compatibility.
orangecms
approved these changes
Feb 25, 2021
|
Awesome, thank you! :) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-env allows Windows users to run npm scripts that set environmental
variables. Single quotes were also replaced with escaped double quotes
for Windows compatibility.
What changes have you introduced?
cross-envmodule added and scripts inpackage.jsonhave been updated to work under Windows. Fixes Error running dev setup on Windows #663Does this PR introduce a breaking change?
No. For development,
npm installwill need to be rerun to install the newcross-envdependency though.Preview / Steps to verify your work:
npm startnow works to begin the application on Windows 10 with both Powershell and CMD. Scripts still work under Linux.