Skip to content

Feature/sensors #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Feature/sensors #612

merged 1 commit into from
Jun 20, 2020

Conversation

orangecms
Copy link
Collaborator

@orangecms orangecms commented Jun 14, 2020

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix
  • Feature implementation
  • Doc updates
  • What changes have you introduced?

#611, #432

  • Does this PR introduce a breaking change?

no

  • Preview / Steps to verify your work:

@orangecms orangecms force-pushed the feature/sensors branch 8 times, most recently from 57c6b69 to 5323929 Compare June 14, 2020 17:05
@orangecms orangecms marked this pull request as ready for review June 14, 2020 17:06
@orangecms
Copy link
Collaborator Author

The main part is done now. Feedback would be great. :)

The Codacy feedback is a bit surprising. Both prettier and eslint are fine with the current state.

Copy link
Contributor

@bessman bessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python code looks fine, can't comment on JS.

@mariobehling
Copy link
Member

Lets move forward and follow up on Codacy later. Merging this therefore. Well-done!

@mariobehling mariobehling merged commit fbd1bf0 into development Jun 20, 2020
@mariobehling mariobehling deleted the feature/sensors branch June 20, 2020 09:18
@mariobehling
Copy link
Member

@orangecms Usually we ask contributors to fork the repository and work in their own fork and then make a PR to the repo. One reason is that we had a lot of abandoned branches in the past and it became more and more difficult to keep track of PRs. People come and go and some people make a PR and dont follow up on change requests. This kind of policy helped us to stay focused. Thanks

@orangecms
Copy link
Collaborator Author

Okay cool, will do from now on.

How is release engineering handled? With a new feature, a minor bump would make sense, right? That would be great for distributions so they can pick up the release from a tag and upgrade packages. I can take care of that if that's okay.

@mariobehling
Copy link
Member

That would be awesome. Thank you!

orangecms added a commit to orangecms/pslab-desktop that referenced this pull request Oct 14, 2020
@orangecms orangecms mentioned this pull request Oct 14, 2020
Abhijay007 pushed a commit to Abhijay007/pslab-desktop that referenced this pull request Oct 31, 2020
cynthi8 pushed a commit to cynthi8/pslab-desktop that referenced this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants