-
Notifications
You must be signed in to change notification settings - Fork 358
Feature/sensors #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sensors #612
Conversation
57c6b69
to
5323929
Compare
The main part is done now. Feedback would be great. :) The Codacy feedback is a bit surprising. Both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python code looks fine, can't comment on JS.
5323929
to
944ac4e
Compare
944ac4e
to
f2c2594
Compare
Lets move forward and follow up on Codacy later. Merging this therefore. Well-done! |
@orangecms Usually we ask contributors to fork the repository and work in their own fork and then make a PR to the repo. One reason is that we had a lot of abandoned branches in the past and it became more and more difficult to keep track of PRs. People come and go and some people make a PR and dont follow up on change requests. This kind of policy helped us to stay focused. Thanks |
Okay cool, will do from now on. How is release engineering handled? With a new feature, a minor bump would make sense, right? That would be great for distributions so they can pick up the release from a tag and upgrade packages. I can take care of that if that's okay. |
That would be awesome. Thank you! |
#611, #432
no