-
Notifications
You must be signed in to change notification settings - Fork 816
feat: added l10n for Deutsch #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: flutter
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR integrates German ( Class diagram for new German localization supportclassDiagram
class AppLocalizations {
<<abstract>>
+String locale
+oscilloscope
+multimeter
+logicAnalyzer
...
}
class AppLocalizationsDe {
+AppLocalizationsDe([String locale = 'de'])
+oscilloscope
+multimeter
+logicAnalyzer
...
}
class AppLocalizationsEn {
+AppLocalizationsEn([String locale = 'en'])
+oscilloscope
+multimeter
+logicAnalyzer
...
}
AppLocalizationsDe --|> AppLocalizations
AppLocalizationsEn --|> AppLocalizations
Class diagram for localization delegate changesclassDiagram
class _AppLocalizationsDelegate {
+isSupported(Locale locale)
+shouldReload(_AppLocalizationsDelegate old)
}
class AppLocalizations {
+supportedLocales : List<Locale>
}
_AppLocalizationsDelegate ..> AppLocalizations : uses
AppLocalizations : supportedLocales = [Locale('de'), Locale('en')]
_AppLocalizationsDelegate : isSupported now supports 'de' and 'en'
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"channel1": "CH1", | ||
"channel2": "CH2", | ||
"channel3": "CH3", | ||
"mic": "MIKROFON", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcnause In all places wherever there is MIC, it is getting translated to MIKROFON. Do we have a short form for MIKROFON in German, as introducing such a long name for channels, distorts UI in some places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in meet, defaulting to MIC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I was too much in "English mode" during the meet to remember that "Mikro" is used as a short form of "Mikrofon" in German. Not sure if is short enough to fit the UI. If not, we should indeed default to MIC.
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/16236569345/artifacts/3518422375 |
Adds localizations for Deutsch to the app.
⚠️ ALL THESE ARE AUTOMATICALLY GENERATED USING A MACHINE TRANSLATOR, as I don't know Deutsch (a bit maybe, but not that much 😅).
@marcnause You are the only one who can review these changes here I guess 😂. You can have a look at the
app_de.arb
file.Summary by Sourcery
Add German translations and enable German locale support in the app
New Features: