Skip to content

feat: added l10n for Deutsch #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: flutter
Choose a base branch
from
Open

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Jul 12, 2025

Adds localizations for Deutsch to the app.
⚠️ ALL THESE ARE AUTOMATICALLY GENERATED USING A MACHINE TRANSLATOR, as I don't know Deutsch (a bit maybe, but not that much 😅).

@marcnause You are the only one who can review these changes here I guess 😂. You can have a look at the app_de.arb file.

Summary by Sourcery

Add German translations and enable German locale support in the app

New Features:

  • Include app_localizations_de.dart with German translations
  • Register German locale in supportedLocales and localization delegate

@AsCress AsCress requested a review from marcnause July 12, 2025 09:18
@AsCress AsCress self-assigned this Jul 12, 2025
Copy link

sourcery-ai bot commented Jul 12, 2025

Reviewer's Guide

This PR integrates German (de) as a supported locale by updating the localization delegate and supported locales list, and includes a new, machine-translated AppLocalizationsDe implementation along with an ARB file stub for German strings.

Class diagram for new German localization support

classDiagram
    class AppLocalizations {
        <<abstract>>
        +String locale
        +oscilloscope
        +multimeter
        +logicAnalyzer
        ...
    }
    class AppLocalizationsDe {
        +AppLocalizationsDe([String locale = 'de'])
        +oscilloscope
        +multimeter
        +logicAnalyzer
        ...
    }
    class AppLocalizationsEn {
        +AppLocalizationsEn([String locale = 'en'])
        +oscilloscope
        +multimeter
        +logicAnalyzer
        ...
    }
    AppLocalizationsDe --|> AppLocalizations
    AppLocalizationsEn --|> AppLocalizations
Loading

Class diagram for localization delegate changes

classDiagram
    class _AppLocalizationsDelegate {
        +isSupported(Locale locale)
        +shouldReload(_AppLocalizationsDelegate old)
    }
    class AppLocalizations {
        +supportedLocales : List<Locale>
    }
    _AppLocalizationsDelegate ..> AppLocalizations : uses
    AppLocalizations : supportedLocales = [Locale('de'), Locale('en')]
    _AppLocalizationsDelegate : isSupported now supports 'de' and 'en'
Loading

File-Level Changes

Change Details Files
Extend localization support to German
  • Imported AppLocalizationsDe in the main localization file
  • Added Locale('de') to supportedLocales
  • Updated isSupported to include 'de'
  • Extended lookupAppLocalizations to return AppLocalizationsDe() for 'de'
lib/l10n/app_localizations.dart
Add autogenerated German translations
  • Introduced a new AppLocalizationsDe class with overrides for all string getters
  • Populated ~1000 lines of German translations via machine translation
lib/l10n/app_localizations_de.dart
Add German ARB file placeholder
  • Created an empty app_de.arb file as a basis for future ARB-driven translations
lib/l10n/app_de.arb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

"channel1": "CH1",
"channel2": "CH2",
"channel3": "CH3",
"mic": "MIKROFON",
Copy link
Collaborator Author

@AsCress AsCress Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcnause In all places wherever there is MIC, it is getting translated to MIKROFON. Do we have a short form for MIKROFON in German, as introducing such a long name for channels, distorts UI in some places.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in meet, defaulting to MIC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I was too much in "English mode" during the meet to remember that "Mikro" is used as a short form of "Mikrofon" in German. Not sure if is short enough to fit the UI. If not, we should indeed default to MIC.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants