fix: Robotic arm UI #2776
Open
fix: Robotic arm UI #2776
+577
−487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR overhauls the Robotic Arm UI to use dynamic, screen-relative sizing for improved responsiveness, refines widget styling (borders, radii, paddings, button themes), refactors the angle input dialog for auto-focus and modular helpers, and cleans up unused imports and constants. Class diagram for updated Robotic Arm UI widgetsclassDiagram
class RoboticArmControls {
+build(context)
-screenHeight
-responsive paddings, heights, and widget styling
}
class AngleInputTopDialog {
+build(context)
-_focusNode
-controller
+_angleButton(angle)
+dispose()
+initState()
}
class PlaybackSummaryDialog {
+build(context)
-responsive constraints and paddings
}
class TimelineScrollView {
+build(context)
-boxWidth
-boxHeight
-timeLineHeight
}
class ServoCard {
+build(context)
-sliderSize (responsive)
}
RoboticArmControls --> AngleInputTopDialog : opens
RoboticArmControls --> PlaybackSummaryDialog : opens
RoboticArmControls --> TimelineScrollView : uses
RoboticArmControls --> ServoCard : uses
ServoCard --> RoboticArmStateProvider : uses
TimelineScrollView --> RoboticArmStateProvider : uses
PlaybackSummaryDialog --> RoboticArmStateProvider : uses
AngleInputTopDialog --> RoboticArmStateProvider : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @rahul31124 - I've reviewed your changes - here's some feedback:
- In TimelineScrollView you reference
screenHeightwithout defining it — addfinal screenHeight = MediaQuery.of(context).size.height;at the top of build to avoid errors. - Extract recurring fractional sizing values (like
screenHeight * 0.026or0.083) into named constants or a helper to reduce magic numbers and improve readability. - You repeat the same border radius, padding, and side styles across multiple widgets — consider centralizing these into shared style constants or theme extensions to enforce consistency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In TimelineScrollView you reference `screenHeight` without defining it — add `final screenHeight = MediaQuery.of(context).size.height;` at the top of build to avoid errors.
- Extract recurring fractional sizing values (like `screenHeight * 0.026` or `0.083`) into named constants or a helper to reduce magic numbers and improve readability.
- You repeat the same border radius, padding, and side styles across multiple widgets — consider centralizing these into shared style constants or theme extensions to enforce consistency.
## Individual Comments
### Comment 1
<location> `lib/view/widgets/robotic_arm_summary.dart:374` </location>
<code_context>
return Container(
- width: 70,
- padding: const EdgeInsets.symmetric(vertical: 8, horizontal: 8),
+ width: MediaQuery.of(context).size.width * 0.09,
+ padding: const EdgeInsets.symmetric(vertical: 4, horizontal: 2),
decoration: BoxDecoration(
</code_context>
<issue_to_address>
Stat card width now depends on screen width, which may cause layout issues on very small or large screens.
Consider adding min and max width constraints to prevent the cards from becoming unusably small or large on different devices.
Suggested implementation:
```
padding: const EdgeInsets.symmetric(vertical: 4, horizontal: 2),
decoration: BoxDecoration(
```
```
decoration: BoxDecoration(
```
```
),
);
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
@AsCress @marcnause, could you please test and confirm if the UI has improved? |
|
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/16238200268/artifacts/3518773557 |
rahul31124
added
Status: Review Required
|
@rahul31124 Merging #2779 introduced conflicts with this PR. Could you please have a look and resolve them? |
|
Hello @marcnause, I have resolved the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improved the responsiveness of the Robotic Arm UI
robotic_arm_.webm
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard coding any value.strings.xml,dimens.xmlorcolors.xml.Summary by Sourcery
Revamp the Robotic Arm UI for better responsiveness and unified styling across all widgets, replacing hardcoded dimensions and styles with relative sizing, streamlined layouts, and dynamic elements.
Enhancements: