fix: accelerometer screen crash and ui

[rahul31124]

Bug Fixes
The accelerometer screen was crashing and not properly visible in landscape mode

Exception
java.lang.IllegalStateException: Fragment AccelerometerDataFragment{ddc3faf} (870ce858-bc85-4f8c-83b6-4f50b7359993) not attached to a context.
at androidx.fragment.app.Fragment.requireContext(Fragment.java:972)
at androidx.fragment.app.Fragment.getResources(Fragment.java:1036)
at androidx.fragment.app.Fragment.getString(Fragment.java:1058)
at io.pslab.fragment.AccelerometerDataFragment.visualizeData(AccelerometerDataFragment.java:429)
Changes
Added if (!isAdded()) return; check at the beginning of the visualizeData() method to ensure that the fragment is properly attached to the activity before attempting to access resources
Used ScrollView to ensure proper UI visibility in landscape mode

Screenshots / Recordings

Before

After

Accelerometer_After.mp4

Checklist:

• No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
• No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
• Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
• No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Fixes a crash in the accelerometer screen and improves UI visibility in landscape mode. The crash was due to the fragment not being attached to a context when accessing resources. This is fixed by adding a check to ensure the fragment is attached before accessing resources. The UI visibility is improved by using ScrollView.

Bug Fixes:

• Fixes a crash in the accelerometer screen due to the fragment not being attached to a context when accessing resources.

Enhancements:

• Improves UI visibility in landscape mode by using ScrollView.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses a crash in the accelerometer screen and improves UI visibility in landscape mode. A check was added to ensure the fragment is attached before accessing resources, preventing the crash. The UI was improved by wrapping the layout in a ScrollView and adjusting dimensions.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added a check to ensure the fragment is attached to the activity before accessing resources.	Added if (!isAdded()) return; at the beginning of the visualizeData() method.	app/src/main/java/io/pslab/fragment/AccelerometerDataFragment.java
Implemented a ScrollView to ensure proper UI visibility in landscape mode.	Wrapped the LinearLayout in a ScrollView. Set a fixed height for the accelerometer fragments. Adjusted margins and padding for better layout.	app/src/main/res/layout/fragment_accelerometer_data.xml app/src/main/res/values/dimens.xml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The added null check if (!isAdded()) return; is a good defensive programming practice.
• Consider using requireContext() instead of getContext() to avoid null pointer exceptions.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/13967870707/artifacts/2787558436