Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2268 Wavegen freq btn problem #2273

Merged
merged 1 commit into from
Oct 28, 2021
Merged

fix: #2268 Wavegen freq btn problem #2273

merged 1 commit into from
Oct 28, 2021

Conversation

Wishy-S
Copy link
Member

@Wishy-S Wishy-S commented Oct 28, 2021

Fixes #2268

Changes:

  • Changed numTicks value to 50 in Wavegenerator activity
  • Specifically in WaveGeneratorActivity, Line 886,893,900,908 has been changed.

Screen shots for the changes:

2021-10-28.18-23-07.mp4

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding any value.
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml.
  • I have reformatted code and fixed indentation in every file included in this pull request
  • My code does not contain any extra lines or extra spaces.
  • I have requested reviews from maintainers.

@CloudyPadmal CloudyPadmal merged commit ea5b575 into fossasia:development Oct 28, 2021
@Wishy-S
Copy link
Member Author

Wishy-S commented Oct 28, 2021

I would really appreciate if you add hacktoberfest-accepted label for this PR
Thank You!

@Wishy-S
Copy link
Member Author

Wishy-S commented Oct 28, 2021

Any idea about how to increase the range for the tick count value as for now it is 0-50 ?

@CloudyPadmal
Copy link
Collaborator

I think it's not possible since the latest version changes in the respective library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants