Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2166 faq section selection of navigation drawer #2266

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Fixes #2166 faq section selection of navigation drawer #2266

merged 1 commit into from
Oct 19, 2021

Conversation

developer-nobita
Copy link
Contributor

Fixes #2166

Changes:

  • Changed navigation index for faq section from 7 to 8 in MainActivity.java file.
  • Reformatted the code.
  • Included Rate App item in the navigation drawer item titles in string.xml file.

Screen shots for the changes:
https://user-images.githubusercontent.com/51999411/137970986-d9b510e8-987a-4a27-9bcc-9ea5d6ec4701.mp4

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding any value.
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml.
  • I have reformatted code and fixed indentation in every file included in this pull request
  • My code does not contain any extra lines or extra spaces.
  • I have requested reviews from maintainers.

@developer-nobita developer-nobita changed the title Fixes #2166 faq section selction of navigation drawer Fixes #2166 faq section selection of navigation drawer Oct 19, 2021
CloudyPadmal
CloudyPadmal approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 👍

@CloudyPadmal CloudyPadmal merged commit 90a6897 into fossasia:development Oct 19, 2021
@CloudyPadmal CloudyPadmal added the Fix Solution to an existing issue in app label Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

Assignees

@developer-nobita developer-nobita

Labels
Fix Solution to an existing issue in app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@developer-nobita @CloudyPadmal