Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated github actions and pull request template #2228

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

CloudyPadmal
Copy link
Collaborator

Fixes #2227

Changes:

  • Upgraded upload-artifacts version to v2
  • Updated apk paths with the correct ones
  • Updated PR template removing APK requirement as APKs are auto-uploaded by GitHub actions

Screenshot/s for the changes:

N/A

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:

N/A

@CloudyPadmal CloudyPadmal self-assigned this Oct 4, 2021
@CloudyPadmal CloudyPadmal added the Chore Changes to things that do not go into production label Oct 4, 2021
@CloudyPadmal CloudyPadmal merged commit a6c6ad4 into fossasia:development Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes to things that do not go into production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub actions script failing to upload artifacts
1 participant