fix: rate app navigate back to FAQ #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CloudyPadmal can you please review the changes? |
CloudyPadmal
requested changes
Apr 1, 2021
Co-authored-by: Padmal <CloudyPadmal@users.noreply.github.com>
CloudyPadmal
requested changes
Apr 3, 2021
| @@ -259,11 +259,12 @@ public boolean onNavigationItemSelected(@NonNull MenuItem item) { | |||
| navItemIndex = 5; | |||
| CURRENT_TAG = TAG_ABOUTUS; | |||
| break; | |||
| case R.id.nav_rate: | |||
| case R.id.nav_rate: | |||
There was a problem hiding this comment.
Revert this indentation
CloudyPadmal
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2198
Changes:
Added a break statement for the case R.id.nav_rate in Main Activity, setUpNavigationView
Screenshot/s for the changes:
Screenrecorder-2021-03-17-22-46-47-717.mp4
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: