Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: icon for developers added #2196

Merged
merged 2 commits into from
Apr 1, 2021
Merged

docs: icon for developers added #2196

merged 2 commits into from
Apr 1, 2021

Conversation

sakshi-1604
Copy link
Contributor

Fixes #2189
Screenshot_1613022496

CodeWithSouma
CodeWithSouma reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@CodeWithSouma CodeWithSouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine but can you change this icon with a simple user icon

@sakshi-1604
Copy link
Contributor Author

ok..I will do that by today
Should I make a new pull request for that or commit new changes in this pull request??

@sakshi-1604
Copy link
Contributor Author

sakshi-1604 commented Feb 13, 2021 •
edited
Loading

I have made following change..
Is it Okay now?
Screenshot_1613191018

CodeWithSouma
CodeWithSouma approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@CodeWithSouma CodeWithSouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @CloudyPadma sir you can marge it

@sakshi-1604 sakshi-1604 reopened this Feb 14, 2021
@CloudyPadmal CloudyPadmal changed the title icon for developers added docs: icon for developers added Apr 1, 2021
@CloudyPadmal CloudyPadmal added the Documentation Non-code related documentation tasks label Apr 1, 2021
@CloudyPadmal CloudyPadmal merged commit 5594acf into fossasia:development Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

@CodeWithSouma CodeWithSouma CodeWithSouma approved these changes

Assignees

@sakshi-1604 sakshi-1604

Labels
Documentation Non-code related documentation tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add icon for developers in About us.
3 participants
@sakshi-1604 @CloudyPadmal @CodeWithSouma