fix: app bar and back button in all sensor activity and add missing MPU925X sensor in sensor list index #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: merge dev into master
|
@CloudyPadmal sir, please check this PR |
|
@CloudyPadmal @mariobehling please review this PR |
CloudyPadmal
reviewed
Apr 1, 2021
There was a problem hiding this comment.
Looks good. Nice work @CodeWithSouma . Can you clean up the branch? There seem to be a lot of commits from development
CloudyPadmal
added
Enhancement
CloudyPadmal
changed the title
Sir, I don't how to squash commit please do something |
|
Aha. They look like small commits for this one PR. I'll squash it. Something similar to https://github.com/fossasia/pslab-android#how-to-git-squash will help squashing commits in future. |
CloudyPadmal
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add app bar and back button in all sensor activity and add missing MPU925X sensor in sensor list index, Fix #2157
@CloudyPadmal
PSLab apk (before the change):before change PSLab.zip
PSLab apk (after the change):after change PSLab.zip