-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pin names #2135
Update pin names #2135
Conversation
You have a lot of false matches for the SEN -> RES pin change. Revert all changes related to SENSOR and SEND. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you just find and replaced the letters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert all binary files (jpegs and pngs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Revert the
*.png
images back - Squash the commits into one (https://github.com/fossasia/pslab-android#how-to-git-squash)
sir please check it. I refactor the code as you want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reverting the PNGs you also reverted W1->SI1 and W2->SI2. Please reapply that part.
You appear to have applied your squash on top of the existing commits instead of replacing them. After a successful squash, the pull request should contain only one commit. Please try again.
can you give me some easy trick to refactor w1 to s1 and w2 to s2. |
grep for W1/2 and change to SI1/2 where applicable. |
Hello @CodeWithSouma , any update on this PR? |
@bessman @CloudyPadmal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Don't worry about squashing, we can do that when we merge.
@CodeWithSouma once you squashed, the git history changes in local. So you have to make a force push. |
Update pin names, Fix #2133
Changed all instances of
ID1/2/3/4 -> LA1/2/3/4
SEN -> RES
AN8 -> VOL
CNTR -> FRQ
W1/2 -> SI1/2