Fixes #2119 #2118 #2134
Merged
Fixes #2119 #2118 #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Tablet layput for multimeter , unlocked landscape mode for some activities and fixed landscape mode of Splash Screen
Added Tablet layput for multimeter , unlocked landscape mode for some activities and fixed landscape mode of Splash Screen
vsasvipul0605
approved these changes
Oct 6, 2020
CloudyPadmal
requested changes
Oct 6, 2020
CloudyPadmal
requested changes
Oct 7, 2020
app/src/main/AndroidManifest.xml
Outdated
| android:windowSoftInputMode="stateHidden|adjustResize" /> | ||
| <activity | ||
| android:name=".activity.LuxMeterActivity" | ||
| android:screenOrientation="portrait" /> | ||
| <activity | ||
| android:name=".activity.WaveGeneratorActivity" | ||
| android:screenOrientation="portrait" /> | ||
| android:screenOrientation="user" /> |
There was a problem hiding this comment.
Revert back and use a layout file for tabs. Refer to comments for a screenshot.
There was a problem hiding this comment.
Ok sir , will do that
app/src/main/AndroidManifest.xml
Outdated
| <activity | ||
| android:name=".activity.PowerSourceActivity" | ||
| android:screenOrientation="portrait" | ||
| android:screenOrientation="user" |
There was a problem hiding this comment.
Revert back and use a layout file for tabs. Refer to comments for a screenshot.
|
|
Now the Multimeter , Wavegenerator and Powersource Activities will remain only in portrait mode in normal sized phones and will have both portrait and landscape modes in Tablets
CloudyPadmal
approved these changes
Oct 12, 2020
Happy to help sir :) |
This was referenced Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2119 #2118
Changes: Added Tablet layout for multimeter , unlocked landscape mode for some activities and fixed landscape mode of Splash Screen
Had to add some values in
dimens.xmlas Tablet layout need more space than normal one.Screenshot/s for the changes:
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for Testing:
tablet_layout-and-landscape_splash_screen.zip
Made_changes asked.zip