Fixed the display issue of multimeter layout on tablet devices … #2129
Conversation
There was a problem hiding this comment.
Hello @Girish-Bharadwaj , I assume this is your first PR for this repo.
First of all, use a meaningful name for the PR title. Secondly, read the PR template and try to fill it. It's asking for screenshots to view the results and an APK to test the app with the changes.
Please update with necessary changes.
Girish-Bharadwaj
changed the title
Sir I have updates the changes as you said.Sorry for inconvinience as it was my first PR and thank you for guiding me Sir. |
|
Hello @Girish-Bharadwaj , Is it possible to make the center knob a bit bigger. As you can see from the screenshot, lot of space is left unused, |
Hello Sir,I have made changes as you said. |
|
Okay, now the knob looks good. But the labels around it also needs to be mapped as it was in the smaller layout. |
Sir made the changes as you said |
| app:layout_constraintCircleRadius="@dimen/multimeter_knobcircle_radius_2_xhdpi" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintStart_toStartOf="parent" | ||
| tools:layout_editor_absoluteY="290dp"/> |
There was a problem hiding this comment.
You might have missed to add this one to dimens.xml
There was a problem hiding this comment.
Looks almost good
Sorry sir,actually it was added by mistake.It was not necessary.Removed it Sir.
OK Sir.Thank you so much for guiding me through my first PR. |
Fixed display issue of multimeter layout on tablet devices
Fixes #2118
Changes: Increased margin of the multimeter and increased height of the display box of multimeter layout by adding new dimens resource file for xhdpi.Also increased the size of the knob along with text in it without hardcoding them.
Screenshot for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
app-fdroid-debug.zip