Fix: Logged data not shown for Gas Sensor. #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
requested changes
May 18, 2020
| @@ -397,6 +397,7 @@ private void visualizeData() { | |||
| mChart.invalidate(); | |||
| } | |||
| } | |||
| writeLogToFile(System.currentTimeMillis(), (float) ppmValue); | |||
There was a problem hiding this comment.
Do we need to cast the double to float? What if the variable is set to float in the first place?
There was a problem hiding this comment.
|
Also squash commits into one and stick to the PR template. |
CloudyPadmal
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1984
Changes:
Entry would be created for case when device is not created to Gas sensor.
Video for the change: https://github.com/VIKAS9899/LogRepo/raw/master/Upload/2020_05_17_14_42_40.mp4
APK for testing: https://github.com/VIKAS9899/LogRepo/raw/master/Upload/pslab_1984.apk