Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2088 Effect on click event for logged data item #2091

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

dheerajkotwani
Copy link
Member

Fixes #2088 Effect on click event on logged data item

Changes:
Added Ripple effect on click for logged data item.
Also added ripple effect on click for map and delete icon on logged data item.

Screenshot/s for the changes:
fix list ripple

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

@dheerajkotwani
Copy link
Member Author

@CloudyPadmal please review this

@CloudyPadmal CloudyPadmal added Enhancement Improvement to an existing feature Status: Review Required Requested reviews from peers and maintainers labels Feb 4, 2020
@cweitat cweitat merged commit 57c176b into fossasia:development Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature Status: Review Required Requested reviews from peers and maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No click effect on clicking list item of logged data
3 participants