-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Methods to Setup PSLab in Android Studio. #2075
Conversation
chore: merge dev into master
@mariobehling @hpdang Mentors please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont understand the change in numbering.
@mariobehling Sir I have added the relative links and have changed the numbering issue. |
@mariobehling @hpdang @nikit19 Mentors please review and merge. |
Is this seem to be copied from #2003 ? |
Yes sir I have taken the basic text from pull request #2003 and have added and made the required changes to the file as the earlier request had been open for 2 months but has been inactive since. Also I felt that this needed to be merged as soon as possible because I too had initially faced a problem because I was unaware of the other methods of setting up the project and felt the need for this to be merged. @CloudyPadmal |
@CloudyPadmal Sir please review and merge as and when possible. |
@CloudyPadmal @mariobehling @hpdang @nikit19 Mentors please review. |
@mariobehling Sir please review this merge request as soon as possible. |
@CloudyPadmal Sir since there hasn't been activity on this pull request by 2003 could you please go ahead and merge this request as soon as possible. |
Duplicate of #2003 |
@NishithP2004 I guess thats already been mentioned above along with the reason. The earlier request has been open since about 2 months with no activity and I feel this is an integral part of the README file and thus have added it. Mentors please merge. |
Also the earlier merger was informed 10 days ago but no response has been received from him so far. |
@mariobehling Sir I have resolved the issue in the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change link please.
@mariobehling Sir I have resolved the changes by making the link relative. |
Fixes #2076
Changes: For the purpose of this request I have updated new PSLab Android Project Build methods to the README.md file to further aid new users to be able to setup the project and build it on Android Studio.
Screenshot/s for the changes:



Checklist: [Please tick following check boxes with
[x]
if the respective task is completed]strings.xml
,dimens.xml
andcolors.xml
without hard-coding themstrings.xml
,dimens.xml
orcolors.xml