Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Methods to Setup PSLab in Android Studio. #2075

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Update Methods to Setup PSLab in Android Studio. #2075

merged 5 commits into from
Feb 4, 2020

Conversation

aryanguls
Copy link
Contributor

@aryanguls aryanguls commented Jan 15, 2020

Fixes #2076

Changes: For the purpose of this request I have updated new PSLab Android Project Build methods to the README.md file to further aid new users to be able to setup the project and build it on Android Studio.

Screenshot/s for the changes:
Screenshot (446)
Screenshot (447)
Screenshot (448)

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

@aryanguls aryanguls changed the title Master Update Methods to Setup PSLab in Android Studio. Jan 15, 2020
@aryanguls
Copy link
Contributor Author

@mariobehling @hpdang Mentors please review.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand the change in numbering.

@aryanguls
Copy link
Contributor Author

@mariobehling Sir I have added the relative links and have changed the numbering issue.

@aryanguls
Copy link
Contributor Author

@mariobehling @hpdang @nikit19 Mentors please review and merge.

@CloudyPadmal
Copy link
Collaborator

Is this seem to be copied from #2003 ?

@CloudyPadmal CloudyPadmal added Question Needs more information Status: Review Required Requested reviews from peers and maintainers labels Jan 17, 2020
@aryanguls
Copy link
Contributor Author

Yes sir I have taken the basic text from pull request #2003 and have added and made the required changes to the file as the earlier request had been open for 2 months but has been inactive since. Also I felt that this needed to be merged as soon as possible because I too had initially faced a problem because I was unaware of the other methods of setting up the project and felt the need for this to be merged. @CloudyPadmal

@aryanguls
Copy link
Contributor Author

@CloudyPadmal Sir please review and merge as and when possible.

@aryanguls
Copy link
Contributor Author

@CloudyPadmal @mariobehling @hpdang @nikit19 Mentors please review.

@CloudyPadmal CloudyPadmal mentioned this pull request Jan 18, 2020
@aryanguls
Copy link
Contributor Author

@mariobehling Sir please review this merge request as soon as possible.

@aryanguls
Copy link
Contributor Author

@CloudyPadmal Sir since there hasn't been activity on this pull request by 2003 could you please go ahead and merge this request as soon as possible.

@NishithP2004
Copy link
Member

Duplicate of #2003

@aryanguls
Copy link
Contributor Author

@NishithP2004 I guess thats already been mentioned above along with the reason. The earlier request has been open since about 2 months with no activity and I feel this is an integral part of the README file and thus have added it. Mentors please merge.

@aryanguls
Copy link
Contributor Author

Also the earlier merger was informed 10 days ago but no response has been received from him so far.

@aryanguls
Copy link
Contributor Author

@mariobehling Sir I have resolved the issue in the file.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change link please.

@aryanguls
Copy link
Contributor Author

@mariobehling Sir I have resolved the changes by making the link relative.

@mariobehling mariobehling merged commit d03f621 into fossasia:development Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Needs more information Status: Review Required Requested reviews from peers and maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement for New Ways To Set PSLab Android Project
4 participants