Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added input limit #2073

Merged
merged 1 commit into from
Jan 15, 2020
Merged

feat: Added input limit #2073

merged 1 commit into from
Jan 15, 2020

Conversation

991rajat
Copy link
Contributor

@991rajat 991rajat commented Jan 13, 2020

Fixes #2071
Added Input Limit

Changes: Added new MinMaxFilter Class

Screenshots for the changes:

GIF-200113_230511

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

Copy link
Contributor

@ho-dor ho-dor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of extra lines can be removed

Copy link

@fcartegnie fcartegnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no clean commit

@its-snorlax
Copy link
Member

@fcartegnie and @ho-dor originally the issue #2071 raised by me and i am waiting for maintainers to approve the issue and assigned it to me in the meantime @991rajat incorrectly raised this PR without letting anyone know.
Once this PR is closed and the issue also assigned to me then I will raise PR for #2071

@991rajat 991rajat requested a review from fcartegnie January 15, 2020 14:24
@mariobehling mariobehling merged commit 30b40c3 into fossasia:development Jan 15, 2020
@its-snorlax
Copy link
Member

its-snorlax commented Jan 15, 2020

@mariobehling This PR is raised incorrectly as I also mentioned before. You can go through the comments section of the issue and can found how @991rajat comes incorrectly and raise this PR in the meantime when I was waiting for the maintainers to approve my issue and steal my contribution. Stealing another person's contribution is this how the community works?

@its-snorlax its-snorlax mentioned this pull request Jan 17, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add limit in input value
6 participants