Added missing screenshots #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better if the instruments would actually show data being displayed. We don't see much going on. |
mariobehling
requested changes
Dec 12, 2019
|
I dont actually have any of the sensors, but i can edit the screenshots to look like they have a reading. |
|
I added the charts using an existing screenshots. I left the values as zero because the existing instrument values were also zero even with a generated chart. |
|
@CloudyPadmal How can @Hasala123 get a reading with data? Let me merge this and we try to get to the next step in a follow up PR. |
techyay
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 3 new screenshots that were missing in the ReadMe file which include the Sensors view, Gas Sensor view and the Dust Sensor view. I have attached a screenshot of the result in my repository[
]