Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2009 Fixed the issue of 'Show Logged Data' menu option of Dust… #2023

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

abhishekbisht1429
Copy link
Contributor

…Sensor showing data from all sensors

Fixes #2009

Changes: Fixed the issue of 'Show Logged Data' menu option showing logs of all other sensors

Screenshot/s for the changes:
fix2009

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
issue2009fix.zip

… of DustSensor showing data from all sensors
@abhishekbisht1429
Copy link
Contributor Author

Hi! @maintainers - could someone please review this pull request.
I have fixed one more issue - #2027 and want to generate a pull request for the same. However this PR has not been reviewed yet so I am unable to generate new PR. So should I just merge both the fixes into one pull request, or is there any other way ?

@mariobehling mariobehling merged commit 24c2e5e into fossasia:development Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Show Logged Data' menu of Dust Sensor showing logged data from other sensors as well
2 participants