Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dust Sensor #1986

Merged
merged 1 commit into from
Oct 15, 2019
Merged

feat: Dust Sensor #1986

merged 1 commit into from
Oct 15, 2019

Conversation

CloudyPadmal
Copy link
Collaborator

@CloudyPadmal CloudyPadmal commented Oct 11, 2019 •
edited
Loading

Fixes #1985

Changes:

  • Dust Sensor
  • Configurations
  • Logging

Screenshot/s for the changes:

Not available

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
dust_sensor.zip

Download this file and rename the extension to apk instead of zip

@CloudyPadmal CloudyPadmal added the Feature New addition to the existing app label Oct 11, 2019
@CloudyPadmal CloudyPadmal requested a review from cweitat October 11, 2019 20:23
@CloudyPadmal CloudyPadmal self-assigned this Oct 11, 2019
@CloudyPadmal
feat: Dust Sensor
741766d 
update: limits
cweitat
cweitat approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@cweitat cweitat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is fine for now. Any other bugs will then open other isues

@CloudyPadmal CloudyPadmal merged commit 22f627b into fossasia:development Oct 15, 2019
@CloudyPadmal CloudyPadmal removed the Feature New addition to the existing app label Oct 15, 2019
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
@CloudyPadmal @makoteq
feat: Dust Sensor (fossasia#1986)
870c61f 
update: limits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitat cweitat cweitat approved these changes

@adityastic adityastic adityastic approved these changes

Assignees

@CloudyPadmal CloudyPadmal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dust Sensor
3 participants
@CloudyPadmal @cweitat @adityastic