Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast message in gas sensor made consistent with all instruments #1983

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

ho-dor
Copy link
Contributor

@ho-dor ho-dor commented Oct 1, 2019

Fixes #1979

Changes: Toast message made consistent with all other instruments.

Screenshot/s for the changes:
20191002_023447

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
toast.zip

@ho-dor ho-dor requested a review from neel1998 October 1, 2019 21:29
@ho-dor
Copy link
Contributor Author

ho-dor commented Oct 5, 2019

Any other issues with this @neel1998 @CloudyPadmal ?

@CloudyPadmal CloudyPadmal merged commit c1590b5 into fossasia:development Oct 11, 2019
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Connected toast blinking continuously unlike any other instrument in gas sensor
3 participants