Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deg text to symbol. #1972

Merged
merged 1 commit into from
Sep 2, 2019
Merged

fix: deg text to symbol. #1972

merged 1 commit into from
Sep 2, 2019

Conversation

rav7kantsingh
Copy link
Contributor

@rav7kantsingh rav7kantsingh commented Sep 1, 2019

Fixes #1967

Changes: [deg was written as text changed to its symbol (\u00b0) ]

Screenshot/s for the changes:
Screenshot_1567363396

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
app-fdroid-debug.apk.zip

@neel1998
Copy link
Member

neel1998 commented Sep 1, 2019

@XDivergent thanks for the PR. check the codacy. It is solvable

@neel1998
Copy link
Member

neel1998 commented Sep 1, 2019

@XDivergent follow the naming convention for the PR title. [Tag]: <title>
In your case it should be
fix: deg test to symbol.

Rest looks good. Great job 👍

@rav7kantsingh
Copy link
Contributor Author

rav7kantsingh commented Sep 1, 2019

@XDivergent thanks for the PR. check the codacy. It is solvable

Can you help in solving this? I am new to these processes.
I cannot understand why it is showing that switch does not contain a break. There is a break.

@rav7kantsingh rav7kantsingh changed the title Fixes #1967 deg text to its symbol fix: deg test to symbol. Sep 1, 2019
@rav7kantsingh rav7kantsingh changed the title fix: deg test to symbol. fix: deg text to symbol. Sep 1, 2019
@neel1998
Copy link
Member

neel1998 commented Sep 1, 2019

@XDivergent thanks for the PR. check the codacy. It is solvable

Can you help in solving this? I am new to these processes.
I am not understanding why it is showing switch does not contain a break. There is a break.

Yes I just saw . I don't know why codacy is giving this error. !!. I think this PR can be merged. @CloudyPadmal @cweitat please check

@neel1998 neel1998 added the Status: Review Required Requested reviews from peers and maintainers label Sep 1, 2019
@CloudyPadmal CloudyPadmal added Fix Solution to an existing issue in app and removed Status: Review Required Requested reviews from peers and maintainers labels Sep 2, 2019
@CloudyPadmal CloudyPadmal merged commit 8dd2c0f into fossasia:development Sep 2, 2019
makoteq pushed a commit to makoteq/pslab-android that referenced this pull request Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Solution to an existing issue in app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add degree symbol to wavegenerator
3 participants